Repository navigation
perf: drop promise layers from async queries - #496
Open
chrispader wants to merge 2 commits into
Open
chrispader wants to merge 2 commits into
chrispader wants to merge 2 commits into
Conversation
executeAsync, executeRawAsync and prepared statement executions went through several async functions and an awaiting queue wrapper, which added promises and microtask turns to every query. They now chain the native promise directly and still report synchronous errors as rejected promises. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every async query went through several async functions before it reached the native promise. Each one added a promise and microtask turns, which made
executeAsyncslower than op-sqlite when many queries were in flight.executeAsync,executeRawAsync, prepared statement executions and the operation queue now chain the native promise directly. Synchronous errors and closed connections still come back as rejected promises, and the queue still updates its state before the caller's continuation runs.On Release builds in margelo/sqlite-bench, 250 point reads in flight on a Galaxy S10 went from 138 to 153 µs per query to 100 to 102 µs (op-sqlite: 86 to 99 µs). Sequential async point reads on an iPhone 14 Pro went from 41.7 to 42.5 µs to 36.9 to 37.0 µs (op-sqlite: 41.7 to 45.7 µs).
Fixes #495
🤖 Generated with Claude Code